Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 306045: Remove three tests from test expectations. (Closed)

Created:
11 years, 2 months ago by Yuta Kitamura
Modified:
9 years, 7 months ago
Reviewers:
hamaji
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Remove three tests from test expectations. These tests are no longer failing. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yuta Kitamura
11 years, 2 months ago (2009-10-22 05:56:01 UTC) #1
Yuta Kitamura
Ping?
11 years, 2 months ago (2009-10-22 08:05:27 UTC) #2
hamaji
On 2009/10/22 08:05:27, Yuta Kitamura wrote: > Ping? Sorry. LGTM, but it would be nice ...
11 years, 2 months ago (2009-10-22 08:21:03 UTC) #3
Yuta Kitamura
The first two tests (svg tests) did not fail all the time. It seemed like ...
11 years, 2 months ago (2009-10-22 08:48:51 UTC) #4
hamaji
11 years, 2 months ago (2009-10-22 09:09:56 UTC) #5
> The first two tests (svg tests) did not fail all the time. It seemed like
jorlow
> mistakenly added these two into test expectations, and I mistakenly recognized
> these as flaky.

Thanks for checking this!

> The last one was fixed in WebKit upstream.

So, it would be better to point the upstream bug or commit in CL description.

Powered by Google App Engine
This is Rietveld 408576698