Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4969)

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 306044: Refactor implementation of BrowserActions, and add support for (Closed)
Patch Set: Make it work on linux too Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extension_process_bindings.js
diff --git a/chrome/renderer/resources/extension_process_bindings.js b/chrome/renderer/resources/extension_process_bindings.js
index ab5fee3c09fffbace60c47850e16b9d8de39781a..3c7d2623cf61797fdb53b78398b083fcf1147cf3 100644
--- a/chrome/renderer/resources/extension_process_bindings.js
+++ b/chrome/renderer/resources/extension_process_bindings.js
@@ -333,7 +333,7 @@ var chrome = chrome || {};
return GetL10nMessage(message_name, placeholders);
}
- var canvas_context;
+ var canvas;
function setIconCommon(details, name, parameters) {
if ("iconIndex" in details) {
sendRequest(name, [details], parameters);
@@ -352,13 +352,13 @@ var chrome = chrome || {};
}
sendCustomRequest(SetExtensionActionIcon, name, [details], parameters);
} else if ("path" in details) {
- if (!canvas_context) {
+ if (!canvas) {
var canvas = document.createElement("canvas");
canvas.width = 19;
canvas.height = 19;
- canvas_context = canvas.getContext('2d');
}
+ var canvas_context = canvas.getContext('2d');
var img = new Image();
var self = this;
img.onerror = function() {

Powered by Google App Engine
This is Rietveld 408576698