Refactor implementation of BrowserActions, and add support for

chrome/common/extensions/extension_action2_unittest.cc

+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/path_service.h"
+#include "chrome/common/chrome_paths.h"
+#include "chrome/common/extensions/extension_action2.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/skia/include/core/SkBitmap.h"
+#include "webkit/glue/image_decoder.h"
+
+static SkBitmap LoadIcon(const std::string& filename) {
+  FilePath path;
+  PathService::Get(chrome::DIR_TEST_DATA, &path);
+  path = path.AppendASCII("extensions").AppendASCII(filename);
+
+  std::string file_contents;
+  file_util::ReadFileToString(path, &file_contents);
+  const unsigned char* data =
+      reinterpret_cast<const unsigned char*>(file_contents.data());
+
+  SkBitmap bitmap;
+  webkit_glue::ImageDecoder decoder;
+  bitmap = decoder.Decode(data, file_contents.length());
+
+  return bitmap;
+}
+
+static bool BitmapsAreEqual(const SkBitmap& bitmap1, const SkBitmap& bitmap2) {
+  void* addr1 = NULL;
+  void* addr2 = NULL;
+
+  bitmap1.lockPixels();
+  addr1 = bitmap1.getAddr32(0, 0);
+  bitmap1.unlockPixels();
+
+  bitmap2.lockPixels();
+  addr2 = bitmap2.getAddr32(0, 0);
+  bitmap2.unlockPixels();
+
+  return 0 == memcmp(addr1, addr2, bitmap1.getSize());
+}
+
+TEST(ExtensionAction2Test, TabSpecificState) {
+  ExtensionAction2 action;
+
+  // title
+  ASSERT_EQ("", action.GetTitle(1));
+  action.SetTitle(ExtensionAction2::kDefaultTabId, "foo");
+  ASSERT_EQ("foo", action.GetTitle(1));
+  ASSERT_EQ("foo", action.GetTitle(100));
+  action.SetTitle(100, "bar");
+  ASSERT_EQ("foo", action.GetTitle(1));
+  ASSERT_EQ("bar", action.GetTitle(100));
+  action.SetTitle(ExtensionAction2::kDefaultTabId, "baz");
+  ASSERT_EQ("baz", action.GetTitle(1));
+  action.ClearAllValuesForTab(100);
+  ASSERT_EQ("baz", action.GetTitle(100));
+
+  // icon
+  SkBitmap icon1 = LoadIcon("icon1.png");
+  SkBitmap icon2 = LoadIcon("icon2.png");
+  ASSERT_TRUE(action.GetIcon(1).isNull());
+  action.SetIcon(ExtensionAction2::kDefaultTabId, icon1);
+  ASSERT_TRUE(BitmapsAreEqual(icon1, action.GetIcon(100)));
+  action.SetIcon(100, icon2);
+  ASSERT_TRUE(BitmapsAreEqual(icon1, action.GetIcon(1)));
+  ASSERT_TRUE(BitmapsAreEqual(icon2, action.GetIcon(100)));
+
+  // badge text
+  ASSERT_EQ("", action.GetBadgeText(1));
+  action.SetBadgeText(ExtensionAction2::kDefaultTabId, "foo");
+  ASSERT_EQ("foo", action.GetBadgeText(1));
+  ASSERT_EQ("foo", action.GetBadgeText(100));
+  action.SetBadgeText(100, "bar");
+  ASSERT_EQ("foo", action.GetBadgeText(1));
+  ASSERT_EQ("bar", action.GetBadgeText(100));
+  action.SetBadgeText(ExtensionAction2::kDefaultTabId, "baz");
+  ASSERT_EQ("baz", action.GetBadgeText(1));
+  action.ClearAllValuesForTab(100);
+  ASSERT_EQ("baz", action.GetBadgeText(100));
+
+  // badge text color
+  ASSERT_EQ(0x00000000, action.GetBadgeTextColor(1));
+  action.SetBadgeTextColor(ExtensionAction2::kDefaultTabId, 0xFFFF0000);
+  ASSERT_EQ(0xFFFF0000, action.GetBadgeTextColor(1));
+  ASSERT_EQ(0xFFFF0000, action.GetBadgeTextColor(100));
+  action.SetBadgeTextColor(100, 0xFF00FF00);
+  ASSERT_EQ(0xFFFF0000, action.GetBadgeTextColor(1));
+  ASSERT_EQ(0xFF00FF00, action.GetBadgeTextColor(100));
+  action.SetBadgeTextColor(ExtensionAction2::kDefaultTabId, 0xFF0000FF);
+  ASSERT_EQ(0xFF0000FF, action.GetBadgeTextColor(1));
+  action.ClearAllValuesForTab(100);
+  ASSERT_EQ(0xFF0000FF, action.GetBadgeTextColor(100));
+
+  // badge background color
+  ASSERT_EQ(0x00000000, action.GetBadgeBackgroundColor(1));
+  action.SetBadgeBackgroundColor(ExtensionAction2::kDefaultTabId, 0xFFFF0000);
+  ASSERT_EQ(0xFFFF0000, action.GetBadgeBackgroundColor(1));
+  ASSERT_EQ(0xFFFF0000, action.GetBadgeBackgroundColor(100));
+  action.SetBadgeBackgroundColor(100, 0xFF00FF00);
+  ASSERT_EQ(0xFFFF0000, action.GetBadgeBackgroundColor(1));
+  ASSERT_EQ(0xFF00FF00, action.GetBadgeBackgroundColor(100));
+  action.SetBadgeBackgroundColor(ExtensionAction2::kDefaultTabId, 0xFF0000FF);
+  ASSERT_EQ(0xFF0000FF, action.GetBadgeBackgroundColor(1));
+  action.ClearAllValuesForTab(100);
+  ASSERT_EQ(0xFF0000FF, action.GetBadgeBackgroundColor(100));
+}
+
+TEST(ExtensionAction2Test, IconOddCases) {
+  ExtensionAction2 action;
+
+  action.SetIcon(ExtensionAction2::kDefaultTabId, LoadIcon("icon1.png"));
+  action.SetDefaultIcon("foo.png");
+  ASSERT_TRUE(action.GetIcon(1).isNull());
+  ASSERT_EQ("foo.png", action.GetDefaultIconPath());
+
+  action.icon_paths()->push_back("a.png");
+  action.icon_paths()->push_back("b.png");
+  action.SetDefaultIcon(1);
+  ASSERT_TRUE(action.GetIcon(1).isNull());
+  ASSERT_EQ("b.png", action.GetDefaultIconPath());
+
+  action.SetIcon(100, LoadIcon("icon1.png"));
+  ASSERT_TRUE(!action.GetIcon(100).isNull());
+  action.SetIcon(ExtensionAction2::kDefaultTabId, LoadIcon("icon1.png"));
+  ASSERT_TRUE(!action.GetIcon(1).isNull());
+  ASSERT_EQ("", action.GetDefaultIconPath());
+}