Issue 306026: Add --trace flag to fast compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306026: Add --trace flag to fast compiler. (Closed)

Created:
11 years, 2 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add --trace flag to fast compiler. Committed: http://code.google.com/p/v8/source/detail?r=3111

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Patch Set 3 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
M	src/arm/fast-codegen-arm.cc	View		3 chunks	+19 lines, -0 lines	0 comments	Download
M	src/ia32/fast-codegen-ia32.cc	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download
M	src/x64/fast-codegen-x64.cc	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

We can emit better code by considering the different cases. Maybe it's not worth optimizing ...

11 years, 2 months ago (2009-10-21 16:12:01 UTC) #2

William Hesse

11 years, 2 months ago (2009-10-22 11:18:20 UTC) #3

ARM version added.

http://codereview.chromium.org/306026/diff/3001/3002
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/306026/diff/3001/3002#newcode143
Line 143: if (source.is_temporary()) {
On 2009/10/21 16:12:01, Kevin Millikin wrote:
> I would write:
> 
> if (source.is_temporary()) {
>   if (FLAG_trace) {
>     __ CallRuntime(Runtime::kTraceExit, 1);
>   } else {
>     __ pop(eax);
>   }
> } else {
>   ASSERT(blah blah blah);
>   if (FLAG_trace) {
>     __ push(Immediate(expr->AsLiteral()->handle()));
>     __ CallRuntime(Runtime::kTraceExit, 1);
>   } else {
>     __ mov(eax, expr->AsLiteral()->handle());
>   }
> }

I prefer keeping it separate, and simple.

Expand Messages | Collapse Messages