Making default to LOGNAME work correctly.

Making default to LOGNAME work correctly.


Modifying gsdcurl to accept username and password from the environment. Switching cros_download_latest_image to use gsdcurl


Merge branch 'master' of ssh://chromiumos-git/crosutils


Switching back to MixedCase. Wrong style guide...


Switching to match external style guide.


Dropping unneeded arg as per review.


Fixing copyright.


Making the prompts go to stderr. Renaming for tab completion.


Adding gsdcurl utility for pulling for Google Storage for Developers.

BUG=None
TEST=None

[djmm, 2010-08-04 00:29:12]

Rubberstamp on the python.  otherwise LGTM

[bradn, 2010-08-04 00:34:44]

No worries, I had the wrong base, it hadn't actually changed much.
-BradN

On Tue, Aug 3, 2010 at 5:29 PM, <djmm@chromium.org> wrote:

> Rubberstamp on the python.  otherwise LGTM
>
>
> http://codereview.chromium.org/3060043/show
>

[jrbarnette, 2010-08-04 01:31:40]

http://codereview.chromium.org/3060043/diff/6001/7001
File bin/cros_gsdcurl.py (right):

http://codereview.chromium.org/3060043/diff/6001/7001#newcode18
bin/cros_gsdcurl.py:18: default_username = os.environ.get('LOGNAME', '')
What's wrong with getpass.getuser()?

[bradn, 2010-08-04 01:41:28]

It didn't want it to be totally opaque for an outside developer (or partner)
who's GAIA account name doesn't match their system username.

-BradN


On Tue, Aug 3, 2010 at 6:31 PM, <jrbarnette@chromium.org> wrote:

>
> http://codereview.chromium.org/3060043/diff/6001/7001
> File bin/cros_gsdcurl.py (right):
>
> http://codereview.chromium.org/3060043/diff/6001/7001#newcode18
> bin/cros_gsdcurl.py:18: default_username = os.environ.get('LOGNAME', '')
> What's wrong with getpass.getuser()?
>
>
> http://codereview.chromium.org/3060043/show
>

[jrbarnette, 2010-08-04 16:54:14]

On Aug 3, 2010, at 6:41 PM, Bradley Nelson wrote:

> It didn't want it to be totally opaque for an outside developer (or  
> partner) who's GAIA account name doesn't match their system username.
>
getpass.getuser() checks LOGNAME and additionally checks other
environment variables that might contain a user name:
     http://docs.python.org/release/2.5.2/lib/module-getpass.html

I'll note that I wasn't suggesting throwing out any logic, I was
just trying to say that getpass.getuser() is a convenient superset
to os.environ.get('LOGNAME', '').

Thanks!


> -BradN
>
>
> On Tue, Aug 3, 2010 at 6:31 PM, <jrbarnette@chromium.org> wrote:
>
> http://codereview.chromium.org/3060043/diff/6001/7001
> File bin/cros_gsdcurl.py (right):
>
> http://codereview.chromium.org/3060043/diff/6001/7001#newcode18
> bin/cros_gsdcurl.py:18: default_username = os.environ.get('LOGNAME',  
> '')
> What's wrong with getpass.getuser()?
>
>
> http://codereview.chromium.org/3060043/show
>

-- jrb

[bradn, 2010-08-04 17:24:37]

Ah, excellent point! That is a good idea.
Will correct shortly.

-BradN


On Wed, Aug 4, 2010 at 9:52 AM, Richard Barnette <jrbarnette@chromium.org>wrote:

> On Aug 3, 2010, at 6:41 PM, Bradley Nelson wrote:
>
>  It didn't want it to be totally opaque for an outside developer (or
>> partner) who's GAIA account name doesn't match their system username.
>>
>>  getpass.getuser() checks LOGNAME and additionally checks other
> environment variables that might contain a user name:
>    http://docs.python.org/release/2.5.2/lib/module-getpass.html
>
> I'll note that I wasn't suggesting throwing out any logic, I was
> just trying to say that getpass.getuser() is a convenient superset
> to os.environ.get('LOGNAME', '').
>
> Thanks!
>
>
>
>  -BradN
>>
>>
>> On Tue, Aug 3, 2010 at 6:31 PM, <jrbarnette@chromium.org> wrote:
>>
>> http://codereview.chromium.org/3060043/diff/6001/7001
>> File bin/cros_gsdcurl.py (right):
>>
>> http://codereview.chromium.org/3060043/diff/6001/7001#newcode18
>> bin/cros_gsdcurl.py:18: default_username = os.environ.get('LOGNAME', '')
>> What's wrong with getpass.getuser()?
>>
>>
>> http://codereview.chromium.org/3060043/show
>>
>>
> -- jrb
>
>