Issue 3060024: Partially revert r53873 (and the valgrind suppression for it).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3060024: Partially revert r53873 (and the valgrind suppression for it). (Closed)

Created:
10 years, 4 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Partially revert r53873 (and the valgrind suppression for it). Moving DataSource destruction to the UI thread appears to just leak memory at shutdown. Finding another way... BUG=34115 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53979

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -23 lines)			Patch
M	chrome/browser/dom_ui/chrome_url_data_manager.h	View	3 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_favicon_source.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_thumbnail_source.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	2 chunks	+1 line, -11 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

10 years, 4 months ago (2010-07-28 17:56:47 UTC) #2

LGTM, one nit

http://codereview.chromium.org/3060024/diff/1/5
File tools/valgrind/memcheck/suppressions.txt (right):

http://codereview.chromium.org/3060024/diff/1/5#newcode3615
tools/valgrind/memcheck/suppressions.txt:3615: big_50484
big?

Expand Messages | Collapse Messages