Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 306002: Another round of test_expectations clean up. (Closed)

Created:
11 years, 2 months ago by Yuta Kitamura
Modified:
9 years, 7 months ago
Reviewers:
hamaji
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Another round of test_expectations clean up. Remove test expectations that are consistently passing, and add a platform tag to another test. BUG=24930, 4360 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29501

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yuta Kitamura
11 years, 2 months ago (2009-10-20 07:32:40 UTC) #1
hamaji
http://codereview.chromium.org/306002/diff/1/2 File webkit/tools/layout_tests/test_expectations.txt (left): http://codereview.chromium.org/306002/diff/1/2#oldcode3148 Line 3148: BUG24930 LINUX : LayoutTests/editing/selection/editable-html-element.html = FAIL Not sure, ...
11 years, 2 months ago (2009-10-20 08:09:02 UTC) #2
Yuta Kitamura
Patch updated. Could you take another look?
11 years, 2 months ago (2009-10-20 08:23:04 UTC) #3
hamaji
11 years, 2 months ago (2009-10-20 09:11:07 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698