Issue 3060004: Fix load_kernel_test, add check to LoadKernel to detect bad args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3060004: Fix load_kernel_test, add check to LoadKernel to detect bad args. (Closed)

Created:
10 years, 5 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, vb, Will Drewry

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@chromiumos-git//vboot_reference.git

Visibility:
Public.

Description

Fix load_kernel_test, add check to LoadKernel to detect bad args. load_kernel_test was failing because it wasn't setting params->kernel_buffer_size before calling LoadKernel(). This fixes that, plus adds some checks to LoadKernel so that it will notice bad params if it happens again.

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -8 lines)			Patch
	M	firmware/lib/vboot_kernel.c	View		2 chunks	+25 lines, -8 lines	0 comments	Download
	M	utility/load_kernel_test.c	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM http://codereview.chromium.org/3060004/diff/1/3 File utility/load_kernel_test.c (right): http://codereview.chromium.org/3060004/diff/1/3#newcode120 utility/load_kernel_test.c:120: lkp.kernel_buffer_size = KERNEL_BUFFER_SIZE; how could this ever work ...

10 years, 5 months ago (2010-07-22 16:50:07 UTC) #2

Will Drewry

10 years, 5 months ago (2010-07-22 18:36:37 UTC) #3

LGTM

Please push with --bypass-hooks to fix build breakage!

Expand Messages | Collapse Messages