Issue 3060002: Remove VirtualFrame::CallStoreIC(void) and CallCommonStoreIC from virtual-fra...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3060002: Remove VirtualFrame::CallStoreIC(void) and CallCommonStoreIC from virtual-fra... (Closed)

Created:
10 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove VirtualFrame::CallStoreIC(void) and CallCommonStoreIC from virtual-frame-x64.cc. Make implementations of CallStoreIC(key, is_contextual) and CallKeyedStoreIC() the same on x64 and ia32. Make ia32 and x64 implementations more alike by moving some functions and changing comments. Committed: http://code.google.com/p/v8/source/detail?r=5113

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -103 lines)			Patch
M	src/x64/codegen-x64.cc	View	1 chunk	+7 lines, -2 lines	1 comment	Download
M	src/x64/virtual-frame-x64.h	View	1 chunk	+5 lines, -28 lines	0 comments	Download
M	src/x64/virtual-frame-x64.cc	View	2 chunks	+72 lines, -73 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 5 months ago (2010-07-21 13:20:13 UTC) #2

LGTM

http://codereview.chromium.org/3060002/diff/1/2
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/3060002/diff/1/2#newcode4848
src/x64/codegen-x64.cc:4848: __ nop();
Not really needed until we port the inlined store IC. I'm planning on doing that
though, so might as well keep it in there. :)

Expand Messages | Collapse Messages