Issue 3059001: Enable fast build by default in build_image and mod_image_for_test.sh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3059001: Enable fast build by default in build_image and mod_image_for_test.sh. (Closed)

Created:
10 years, 5 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Enable fast build by default in build_image and mod_image_for_test.sh. The fast build is stable enough now that we can enable it for everybody. I ran the build constantly all weekend on two machines and I only ran into one (rare) error, which I've fixed in a separate patch. See <http://codereview.chromium.org/2856048/show>; TEST=Ran lots and lots of fast builds BUG=none

Patch Set 1 #

Patch Set 2 : Only enable by default in non-official builds #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
M	build_image	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	common.sh	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	mod_image_for_test.sh	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

davidjames

Per discussion with Brad, updated to only enable by default on non-official builds. PTAL.

10 years, 5 months ago (2010-07-28 01:14:59 UTC) #3

LGTM

Expand Messages | Collapse Messages