Issue 3058047: Tweak appearances of "Languages and Input" options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3058047: Tweak appearances of "Languages and Input" options. (Closed)

Created:
10 years, 4 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
mazda

CC:
chromium-reviews, dhg, Paweł Hajdan Jr., arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Tweak appearances of "Languages and Input" options. - Set the fixed width per suggestion from Cole - Reduce some padding/margin so the overlay can fit in the netbook screen. TEST=manually on the netbook BUG=chromium-os:4573 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55046

Patch Set 1 #

Patch Set 2 : re-upload #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/chromeos_language_options.css	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

arv1

LGTM In general when a CSS value is 0 you should not use a unit ...

10 years, 4 months ago (2010-08-05 17:07:55 UTC) #3

satorux1

On 2010/08/05 17:07:55, arv1 wrote: > LGTM > > In general when a CSS value ...

10 years, 4 months ago (2010-08-06 00:38:50 UTC) #4

arv (Not doing code reviews)

10 years, 4 months ago (2010-08-06 00:51:37 UTC) #5

https://wiki.corp.google.com/twiki/bin/view/Main/CSSStyleGuide

erik



On Thu, Aug 5, 2010 at 17:38,  <satorux@chromium.org> wrote:
> On 2010/08/05 17:07:55, arv1 wrote:
>>
>> LGTM
>
>> In general when a CSS value is 0 you should not use a unit (according to
>> our CSS style guide)
>
> Thank you for pointing this out. I'll fix these shortly.
>
> BTW, do you have a pointer to our CSS style guide?
>
>
>
>> On Aug 5, 2010 2:20:11 AM PDT, mazda <mailto:mazda@chromium.org> wrote:
>> > On 2010/08/05 09:19:15, satorux1 wrote:
>> > lgtm
>
>
>
>
> http://codereview.chromium.org/3058047/show
>

Expand Messages | Collapse Messages