Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: chrome/browser/dom_ui/browser_options_handler.h

Issue 3058018: Revert 53849 - Implement most of the startup page controls in DOMUI prefs... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/custom_home_pages_table_model.cc ('k') | chrome/browser/dom_ui/browser_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/browser_options_handler.h
===================================================================
--- chrome/browser/dom_ui/browser_options_handler.h (revision 53856)
+++ chrome/browser/dom_ui/browser_options_handler.h (working copy)
@@ -6,18 +6,14 @@
#define CHROME_BROWSER_DOM_UI_BROWSER_OPTIONS_HANDLER_H_
#pragma once
-#include "app/table_model_observer.h"
#include "chrome/browser/dom_ui/options_ui.h"
#include "chrome/browser/search_engines/template_url_model.h"
#include "chrome/browser/shell_integration.h"
-class CustomHomePagesTableModel;
-
// Chrome browser options page UI handler.
class BrowserOptionsHandler : public OptionsPageUIHandler,
public ShellIntegration::DefaultBrowserObserver,
- public TemplateURLModelObserver,
- public TableModelObserver {
+ public TemplateURLModelObserver {
public:
BrowserOptionsHandler();
virtual ~BrowserOptionsHandler();
@@ -35,12 +31,6 @@
// TemplateURLModelObserver implementation.
virtual void OnTemplateURLModelChanged();
- // TableModelObserver implementation.
- virtual void OnModelChanged();
- virtual void OnItemsChanged(int start, int length);
- virtual void OnItemsAdded(int start, int length);
- virtual void OnItemsRemoved(int start, int length);
-
private:
// Makes this the default browser. Called from DOMUI.
void BecomeDefaultBrowser(const Value* value);
@@ -48,12 +38,6 @@
// Sets the search engine at the given index to be default. Called from DOMUI.
void SetDefaultSearchEngine(const Value* value);
- // Removes the startup page at the given indexes. Called from DOMUI.
- void RemoveStartupPages(const Value* value);
-
- // Sets the startup page set to the current pages. Called from DOMUI.
- void SetStartupPagesToCurrentPages(const Value* value);
-
// Returns the string ID for the given default browser state.
int StatusStringIdForState(ShellIntegration::DefaultBrowserState state);
@@ -64,24 +48,10 @@
// Updates the UI with the given state for the default browser.
void SetDefaultBrowserUIString(int status_string_id);
- // Loads the current set of custom startup pages and reports it to the DOMUI.
- void UpdateStartupPages();
-
- // Loads the possible default search engine list and reports it to the DOMUI.
- void UpdateSearchEngines();
-
- // Writes the current set of startup pages to prefs.
- void SaveStartupPagesPref();
-
scoped_refptr<ShellIntegration::DefaultBrowserWorker> default_browser_worker_;
TemplateURLModel* template_url_model_; // Weak.
- // TODO(stuartmorgan): Once there are no other clients of
- // CustomHomePagesTableModel, consider changing it to something more like
- // TemplateURLModel.
- scoped_ptr<CustomHomePagesTableModel> startup_custom_pages_table_model_;
-
DISALLOW_COPY_AND_ASSIGN(BrowserOptionsHandler);
};
« no previous file with comments | « chrome/browser/custom_home_pages_table_model.cc ('k') | chrome/browser/dom_ui/browser_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698