Issue 3058012: Add support for Radial Gradient Brush and Bitmap Brush to gfx::Canvas....

Issue 3058012: Add support for Radial Gradient Brush and Bitmap Brush to gfx::Canvas.... (Closed)

Created:
10 years, 5 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add support for Radial Gradient Brush and Bitmap Brush to gfx::Canvas. BUG=none TEST=see unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54148

Patch Set 4 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+278 lines, -18 lines)			Patch
M	gfx/canvas.h	View	1 2 3	2 chunks	+31 lines, -3 lines	0 comments	Download
M	gfx/canvas_direct2d.h	View	1 2 3	1 chunk	+11 lines, -0 lines	0 comments	Download
M	gfx/canvas_direct2d.cc	View	1 2 3	3 chunks	+79 lines, -14 lines	0 comments	Download
M	gfx/canvas_direct2d_unittest.cc	View	1 2 3	3 chunks	+60 lines, -0 lines	0 comments	Download
M	gfx/canvas_skia.h	View	1 2 3	1 chunk	+11 lines, -0 lines	0 comments	Download
M	gfx/canvas_skia.cc	View	1 2 3	2 chunks	+34 lines, -0 lines	0 comments	Download
M	gfx/gfx.gyp	View	1 2 3	4 chunks	+48 lines, -1 line	0 comments	Download
M	tools/grit/resource_ids	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/3058012/diff/9001/10003 File gfx/canvas_direct2d.cc (right): http://codereview.chromium.org/3058012/diff/9001/10003#newcode53 gfx/canvas_direct2d.cc:53: D2D1_GRADIENT_STOP* gradient_stops = new D2D1_GRADIENT_STOP[position_count]; It looks like this ...

10 years, 5 months ago (2010-07-27 04:53:44 UTC) #2

LGTM

Expand Messages | Collapse Messages