Issue 3058011: Add "pushed" as a state a TextButton can show (alongside "normal" and "hover"...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3058011: Add "pushed" as a state a TextButton can show (alongside "normal" and "hover"... (Closed)

Created:
10 years, 5 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add "pushed" as a state a TextButton can show (alongside "normal" and "hover"). BUG=50107 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53847

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -24 lines)			Patch
M	chrome/browser/autofill/autofill_cc_infobar_win.cc	View	4	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/clock_menu_button.cc	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/status/language_menu_button.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/status_area_button.cc	View	4	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/browser_action_test_util_views.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/wrench_menu.cc	View	3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/controls/button/text_button.h	View	2 3 4	5 chunks	+14 lines, -6 lines	1 comment	Download
M	views/controls/button/text_button.cc	View	2 3 4	6 chunks	+15 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

10 years, 5 months ago (2010-07-27 21:20:09 UTC) #3

LGTM

http://codereview.chromium.org/3058011/diff/10003/29008
File views/controls/button/text_button.h (right):

http://codereview.chromium.org/3058011/diff/10003/29008#newcode139
views/controls/button/text_button.h:139: void SetShowMultipleStates(bool
show_multiple_states);
I think this should be SetShowMultipleIconStates to make it clear this is
applying to the button icon.

Also, the comment would then read something like:

// Sets whether or not to show the hot and pushed states of the button icon (if
present) in addition to the normal state. Defaults to true.

Expand Messages | Collapse Messages