Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 3058006: Add API on host registration page. (Closed)

Created:
10 years, 5 months ago by Nikita (slow)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr., zel
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Add API on host registration page. Add test register form page. Added extra debug logging. Full cycle: 1. Register screen navigates to chrome://register (host page). 2. host page requests DOMUI for register form URL: getRegistrationUrl msg on DOM load event. 3. Once URL is received it is loaded in an iframe. 4. When register form is loaded it sends get_user_info msg via postMessage to host page. 5. host page requests DOMUI for system/user info: getUserInfo msg. 6. Once info is received host page sends that to an iframe with set_user_info msg. 7. Register form notifies host page on registration success/skip status with complete_registration msg. 8. Based on registration result host page navigates to cros://register/[success|skipped] so that Out of box wizard is notified. BUG= http://crosbug.com/4813 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53768

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : test merge #

Total comments: 20

Patch Set 4 : fix #

Patch Set 5 : fix test change #

Total comments: 6

Patch Set 6 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -21 lines) Patch
M chrome/browser/chromeos/login/registration_screen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/web_page_view.cc View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/register_page_ui.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/host_registration_page.html View 1 2 3 1 chunk +41 lines, -15 lines 0 comments Download
A chrome/test/data/register_form.html View 2 3 4 5 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nikita (slow)
Erik, please review JS/HTML part.
10 years, 5 months ago (2010-07-23 11:03:41 UTC) #1
whywhat
LGTM for C++ part. http://codereview.chromium.org/3058006/diff/5001/6004 File chrome/browser/dom_ui/register_page_ui.cc (right): http://codereview.chromium.org/3058006/diff/5001/6004#newcode166 chrome/browser/dom_ui/register_page_ui.cc:166: std::string url = WizardController::default_controller()-> const ...
10 years, 5 months ago (2010-07-23 11:28:51 UTC) #2
arv (Not doing code reviews)
What is you i18n plan? http://codereview.chromium.org/3058006/diff/5001/6005 File chrome/browser/resources/host_registration_page.html (right): http://codereview.chromium.org/3058006/diff/5001/6005#newcode51 chrome/browser/resources/host_registration_page.html:51: var msg = {type: ...
10 years, 5 months ago (2010-07-23 18:51:34 UTC) #3
Nikita (slow)
As for i18n plan: Host registration page doesn't hold any content. We'll be passing selected ...
10 years, 5 months ago (2010-07-26 14:38:22 UTC) #4
arv (Not doing code reviews)
lgtm http://codereview.chromium.org/3058006/diff/19002/21005 File chrome/browser/resources/host_registration_page.html (right): http://codereview.chromium.org/3058006/diff/19002/21005#newcode14 chrome/browser/resources/host_registration_page.html:14: width: 100%; No need for width when both ...
10 years, 5 months ago (2010-07-26 22:44:38 UTC) #5
Nikita (slow)
http://codereview.chromium.org/3058006/diff/19002/21005 File chrome/browser/resources/host_registration_page.html (right): http://codereview.chromium.org/3058006/diff/19002/21005#newcode14 chrome/browser/resources/host_registration_page.html:14: width: 100%; On 2010/07/26 22:44:38, arv wrote: > No ...
10 years, 5 months ago (2010-07-27 08:51:37 UTC) #6
arv (Not doing code reviews)
10 years, 5 months ago (2010-07-27 18:38:12 UTC) #7
On Tue, Jul 27, 2010 at 01:51,  <nkostylev@chromium.org> wrote:
>
> http://codereview.chromium.org/3058006/diff/19002/21005
> File chrome/browser/resources/host_registration_page.html (right):
>
> http://codereview.chromium.org/3058006/diff/19002/21005#newcode14
> chrome/browser/resources/host_registration_page.html:14: width: 100%;
> On 2010/07/26 22:44:38, arv wrote:
>>
>> No need for width when both left and right are set (same for height)
>
> If I don't specify 100% for w/h then iframe takes only that space that
> is required by it's content.
> I need it to fill 100% space of the host page.

You are right. Replaced content sucks. However, you can use left+width
and skip the right.

> http://codereview.chromium.org/3058006/diff/19002/21006
> File chrome/test/data/register_form.html (right):
>
> http://codereview.chromium.org/3058006/diff/19002/21006#newcode14
> chrome/test/data/register_form.html:14: padding: 10px 10px 10px 10px;
> On 2010/07/26 22:44:38, arv wrote:
>>
>> padding: 10px;
>
> Done.
>
> http://codereview.chromium.org/3058006/diff/19002/21006#newcode53
> chrome/test/data/register_form.html:53: $('messageInfo').textContent =
> 'e.origin: ' + e.origin + ', e.data.domain: ' + e.data.domain;
> On 2010/07/26 22:44:38, arv wrote:
>>
>> long line
>
> Done.
>
> http://codereview.chromium.org/3058006/show
>

Powered by Google App Engine
This is Rietveld 408576698