Checking in FFmpeg regression testing framework.

Checking in FFmpeg regression testing framework.

Basically verifies that our assumptions on how FFmpeg works opening/seeking/parsing files remain intact.

BUG=19865
TEST=run ffmpeg_unittests :)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53818

[scherkus (not reviewing), 2010-07-21 01:24:04]

This isn't really ready to go but if you want to look at it go for it.

Alpha you can use this to trigger that test case I think.

Test data is from go/videotestmatrix (sync series of videos).

Currently all tests passing on trunk version.  Rolling FFmpeg *might* break
them, but that'd be a good thing.

[Paweł Hajdan Jr., 2010-07-21 01:29:10]

Drive-by with test comments.

http://codereview.chromium.org/3058004/diff/1/2
File media/ffmpeg/ffmpeg_unittest.cc (right):

http://codereview.chromium.org/3058004/diff/1/2#newcode207
media/ffmpeg/ffmpeg_unittest.cc:207: CHECK(has_audio());
nit: Can we use an EXPECT_TRUE and early return combo? Like this:

EXPECT_TRUE(has_audio());
if (!has_audio())
  return false;

We should try to avoid crashing entire unit tests binary, which CHECK would do.

http://codereview.chromium.org/3058004/diff/1/2#newcode246
media/ffmpeg/ffmpeg_unittest.cc:246: CHECK(decoded_audio_time_ !=
static_cast<int64>(AV_NOPTS_VALUE));
Similarly here.

http://codereview.chromium.org/3058004/diff/1/2#newcode260
media/ffmpeg/ffmpeg_unittest.cc:260: CHECK(has_video());
And here. Please also check other places in this file if possible.

[scherkus (not reviewing), 2010-07-21 19:37:15]

Alpha: this version compiles with FFmpeg DEPS @ r53025

If you copy counting.ogv into /media/test/data/content and run with
--gtest_filter=*counting* you'll hit the repro case where we seek but our first
decoded video frame is at 4 seconds

http://codereview.chromium.org/3058004/diff/1/2
File media/ffmpeg/ffmpeg_unittest.cc (right):

http://codereview.chromium.org/3058004/diff/1/2#newcode207
media/ffmpeg/ffmpeg_unittest.cc:207: CHECK(has_audio());
On 2010/07/21 01:29:11, Paweł Hajdan Jr. wrote:
> nit: Can we use an EXPECT_TRUE and early return combo? Like this:
> 
> EXPECT_TRUE(has_audio());
> if (!has_audio())
>   return false;
> 
> We should try to avoid crashing entire unit tests binary, which CHECK would
do.

Done.

http://codereview.chromium.org/3058004/diff/1/2#newcode246
media/ffmpeg/ffmpeg_unittest.cc:246: CHECK(decoded_audio_time_ !=
static_cast<int64>(AV_NOPTS_VALUE));
On 2010/07/21 01:29:11, Paweł Hajdan Jr. wrote:
> Similarly here.

Done.

http://codereview.chromium.org/3058004/diff/1/2#newcode260
media/ffmpeg/ffmpeg_unittest.cc:260: CHECK(has_video());
On 2010/07/21 01:29:11, Paweł Hajdan Jr. wrote:
> And here. Please also check other places in this file if possible.

Done.

[Paweł Hajdan Jr., 2010-07-21 20:16:14]

Code I commented in the drive-by LGTM.

[Alpha Left Google, 2010-07-26 22:00:42]

LGTM. I think this test is becoming very useful since we can use that to tweat
different seek flags / patch.