Issue 3057012: FTP: minor cleanups to the unit tests:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3057012: FTP: minor cleanups to the unit tests: (Closed)

Created:
10 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
eroman, wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

FTP: minor cleanups to the unit tests: - remove obsolete workaround for us opening two data connections, we no longer do this - add comments explaining the 599 FTP error code BUG=none TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53806

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -6 lines)			Patch
	M	net/ftp/ftp_network_transaction_unittest.cc	View		16 chunks	+33 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

10 years, 4 months ago (2010-07-26 21:48:11 UTC) #2

LGTM.

Nit: list BUG= before TEST= in a CL's description.
See the examples in
http://sites.google.com/a/chromium.org/dev/developers/contributing-code

Expand Messages | Collapse Messages