Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 3057012: FTP: minor cleanups to the unit tests: (Closed)

Created:
10 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
eroman, wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

FTP: minor cleanups to the unit tests: - remove obsolete workaround for us opening two data connections, we no longer do this - add comments explaining the 599 FTP error code BUG=none TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M net/ftp/ftp_network_transaction_unittest.cc View 16 chunks +33 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
10 years, 4 months ago (2010-07-26 20:51:12 UTC) #1
wtc
10 years, 4 months ago (2010-07-26 21:48:11 UTC) #2
LGTM.

Nit: list BUG= before TEST= in a CL's description.
See the examples in
http://sites.google.com/a/chromium.org/dev/developers/contributing-code

Powered by Google App Engine
This is Rietveld 408576698