Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 3056049: Object.seal(obj) and Object.freeze(obj) should return the input obj.... (Closed)

Created:
10 years, 4 months ago by burcu
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Object.seal(obj) and Object.freeze(obj) should return the input obj. BUG=http://code.google.com/p/v8/issues/detail?id=809 TEST=Seal/freeze an object and check if Object.seal and Object.freeze returns the given object. Committed: http://code.google.com/p/v8/source/detail?r=5176

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8natives.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/object-freeze.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/object-seal.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
burcu
10 years, 4 months ago (2010-08-05 07:02:21 UTC) #1
Søren Thygesen Gjesse
http://codereview.chromium.org/3056049/diff/1/3 File src/v8natives.js (right): http://codereview.chromium.org/3056049/diff/1/3#newcode49 src/v8natives.js:49: function InstallFunctions(object, attributes, functions) { I think you accidentally ...
10 years, 4 months ago (2010-08-05 07:45:42 UTC) #2
burcu
Fixing the wrong indent -- sorry.
10 years, 4 months ago (2010-08-05 09:27:13 UTC) #3
Søren Thygesen Gjesse
LGTM I will go ahead and commit ti.
10 years, 4 months ago (2010-08-05 10:54:16 UTC) #4
Søren Thygesen Gjesse
10 years, 4 months ago (2010-08-05 10:57:32 UTC) #5
On 2010/08/05 10:54:16, Søren Gjesse wrote:
> LGTM
> 
> I will go ahead and commit ti.

Committed: http://code.google.com/p/v8/source/detail?r=5176, closing issue.

Thanks for the patch!

Powered by Google App Engine
This is Rietveld 408576698