Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 3056040: Revert 54405 - Fix late binding induced mismatch of Socket and AuthController... (Closed)

Created:
10 years, 4 months ago by ncarter (slow)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 54405 - Fix late binding induced mismatch of Socket and AuthController [Reason for revert: large spike in crash rate on reliability bots] ClientSocketPool treats all pending SocketParams as interchangeable. Therefore they can not contain any connection specific data. This only affects the Http Proxy tunnel case. The lowest risk change to fix this problem is to create the HttpAuthController in the HttpProxyClientSocket. If we get a 407 and need to restart the Tunnel, the pending HttpProxyClientSocket is returned to the HttpNetworkTransaction in the additional error state of the connection and then complete the auth in a pair of states in the HttpNetworkTransaction. This reintroduces a dependency between tunnel setup and the HttpNetworkTransaction, but that will need to be fixed at a later date. BUG=49493, 50822 TEST=existing unit tests + manually visiting many SSL sites through a kerberized http proxy. Review URL: http://codereview.chromium.org/3058013 TBR=vandebo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -359 lines) Patch
M net/base/net_error_list.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.h View 3 chunks +0 lines, -7 lines 0 comments Download
M net/http/http_network_transaction.cc View 8 chunks +29 lines, -77 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +0 lines, -105 lines 0 comments Download
M net/http/http_proxy_client_socket.h View 4 chunks +6 lines, -11 lines 0 comments Download
M net/http/http_proxy_client_socket.cc View 7 chunks +16 lines, -36 lines 0 comments Download
MM net/http/http_proxy_client_socket_pool.h View 3 chunks +4 lines, -5 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 3 chunks +5 lines, -9 lines 0 comments Download
MM net/http/http_proxy_client_socket_pool_unittest.cc View 16 chunks +31 lines, -39 lines 0 comments Download
MM net/socket/client_socket_handle.h View 3 chunks +0 lines, -7 lines 0 comments Download
MM net/socket/client_socket_handle.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM net/socket/socket_test_util.h View 1 chunk +40 lines, -0 lines 0 comments Download
MM net/socket/socket_test_util.cc View 1 chunk +47 lines, -0 lines 0 comments Download
MM net/socket/ssl_client_socket_pool.h View 2 chunks +3 lines, -1 line 0 comments Download
MM net/socket/ssl_client_socket_pool.cc View 5 chunks +20 lines, -8 lines 0 comments Download
MM net/socket/ssl_client_socket_pool_unittest.cc View 27 chunks +183 lines, -53 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ncarter (slow)
10 years, 4 months ago (2010-08-02 22:02:57 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698