Issue 3056020: Review comments for pragmaonce.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3056020: Review comments for pragmaonce.py (Closed)

Created:
10 years, 5 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Evan Martin

CC:
chromium-reviews, pam+watch_chromium.org

Visibility:
Public.

Description

Review comments for pragmaonce.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53665

Patch Set 1 #

Total comments: 3

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/pragmaonce/pragmaonce.py	View		2 chunks	+3 lines, -3 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LG http://codereview.chromium.org/3056020/diff/1/2 File tools/pragmaonce/pragmaonce.py (right): http://codereview.chromium.org/3056020/diff/1/2#newcode22 tools/pragmaonce/pragmaonce.py:22: m1 = re.match(r'^#ifndef ([A-Z_0-9]+$)', lines[i]) I would take ...

10 years, 5 months ago (2010-07-26 18:58:42 UTC) #2

Nico

10 years, 5 months ago (2010-07-26 20:13:02 UTC) #3

http://codereview.chromium.org/3056020/diff/1/2
File tools/pragmaonce/pragmaonce.py (right):

http://codereview.chromium.org/3056020/diff/1/2#newcode22
tools/pragmaonce/pragmaonce.py:22: m1 = re.match(r'^#ifndef ([A-Z_0-9]+$)',
lines[i])
On 2010/07/26 18:58:42, Mark Mentovai wrote:
> I would take the $ out of the () in each of these.

d'ohne

Expand Messages | Collapse Messages