Issue 3056005: AutoFill Profiles dialog handles multi-select and delete on Mac (Follow up)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3056005: AutoFill Profiles dialog handles multi-select and delete on Mac (Follow up) (Closed)

Created:
10 years, 5 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

AutoFill Profiles dialog handles multi-select and delete on Mac (Follow up) Changes index set traversal logic for multi-select and delete of AutoFillDialog table elements on Mac. This is follow-up from Thakis' review comment in review http://codereview.chromium.org/3039014. BUG=49344 TEST=AutoFillDialogControllerTest.DeleteMultiple Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53199

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing nits. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
	M	chrome/browser/autofill/autofill_dialog_controller_mac.mm	View	1	2 chunks	+7 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

LG, thanks! Two nits below. http://codereview.chromium.org/3056005/diff/1/2 File chrome/browser/autofill/autofill_dialog_controller_mac.mm (right): http://codereview.chromium.org/3056005/diff/1/2#newcode371 chrome/browser/autofill/autofill_dialog_controller_mac.mm:371: // to to set ...

10 years, 5 months ago (2010-07-20 21:49:22 UTC) #2

dhollowa

10 years, 5 months ago (2010-07-20 21:56:21 UTC) #3

http://codereview.chromium.org/3056005/diff/1/2
File chrome/browser/autofill/autofill_dialog_controller_mac.mm (right):

http://codereview.chromium.org/3056005/diff/1/2#newcode371
chrome/browser/autofill/autofill_dialog_controller_mac.mm:371: // to to set new
selection below.
On 2010/07/20 21:49:22, Nico wrote:
> s/to to/to/

Done.

http://codereview.chromium.org/3056005/diff/1/2#newcode391
chrome/browser/autofill/autofill_dialog_controller_mac.mm:391: [tableView_
selectRowIndexes:[NSIndexSet indexSet] byExtendingSelection:NO];
On 2010/07/20 21:49:22, Nico wrote:
> [tableView_ deselectAll:self];?

Nice.  Done.

Expand Messages | Collapse Messages