Issue 3056002: Make the homedir check a bit simpler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3056002: Make the homedir check a bit simpler. (Closed)

Created:
10 years, 5 months ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
Nick Sanders

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Make the homedir check a bit simpler. Rather than using split, we can just use os.path.basename(path) to get the username from the homedir name. This is a bit simpler. I've also added a comment which I missed in my last commit. TEST=Ran ./parallel_emerge, verified the new method of getting PORTAGE_USERNAME gets the right username. BUG=none

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	parallel_emerge	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages