Issue 3054035: Cleanup newly allocated device nodes in case of configuration failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3054035: Cleanup newly allocated device nodes in case of configuration failure. (Closed)

Created:
10 years, 4 months ago by Milind Choudhary

Modified:
9 years, 7 months ago

Reviewers:
robotboy, micahc, Brian Daugherty, Randall Spangler, chromeboy, amoljadi

CC:
chromium-os-reviews_chromium.org, dneiss, robotboy, chromeboy, amoljadi, cros.approvers_codeaurora.org, Micah C

Base URL:
git://git.chromium.org/u-boot.git

Visibility:
Public.

Description

Cleanup newly allocated device nodes in case of configuration failure. If probe of a newly connected device fails for some reason, clean up the allocated entry in usb_dev array. Change-Id: I90fc5dde3bffb95cee19da2423fe3ff9ac546214 Signed-off-by: Milind Choudhary <milindc@codeaurora.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d230412

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	common/usb.c	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Milind Choudhary

Please review this patch and add any reviewers you think are concerned with this topic. ...

10 years, 4 months ago (2010-08-02 17:10:19 UTC) #1

robotboy

10 years, 2 months ago (2010-10-13 17:41:19 UTC) #3

LGTM, thanks.  Could you also send this patch upstream?  I checked this against
upstream and they have this bug there too.

Thanks,
    Anton

Expand Messages | Collapse Messages