Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3433)

Unified Diff: chrome/browser/sync/engine/syncer_unittest.cc

Issue 3054021: Sync: set BASE_VERSION to entry.version() instead of 0 when changing (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Sync to trunk; add comment per chron. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/process_updates_command.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/syncer_unittest.cc
diff --git a/chrome/browser/sync/engine/syncer_unittest.cc b/chrome/browser/sync/engine/syncer_unittest.cc
index 70f25e0c072ad835c0cb070339aaf0447198caa4..ae6e597c56c6318319f918f7aa95a37da24ad40d 100644
--- a/chrome/browser/sync/engine/syncer_unittest.cc
+++ b/chrome/browser/sync/engine/syncer_unittest.cc
@@ -4363,8 +4363,8 @@ TEST_F(SyncerTest, ClientTagClashWithinBatchOfUpdates) {
Entry tag_a(&trans, GET_BY_CLIENT_TAG, "tag a");
ASSERT_TRUE(tag_a.good());
- ASSERT_TRUE(tag_a.Get(ID).ServerKnows());
- ASSERT_TRUE(ids_.FromNumber(1) == tag_a.Get(ID));
+ EXPECT_TRUE(tag_a.Get(ID).ServerKnows());
+ EXPECT_EQ(ids_.FromNumber(1), tag_a.Get(ID));
EXPECT_FALSE(tag_a.Get(IS_DEL));
EXPECT_FALSE(tag_a.Get(IS_UNAPPLIED_UPDATE));
EXPECT_FALSE(tag_a.Get(IS_UNSYNCED));
@@ -4374,8 +4374,8 @@ TEST_F(SyncerTest, ClientTagClashWithinBatchOfUpdates) {
Entry tag_b(&trans, GET_BY_CLIENT_TAG, "tag b");
ASSERT_TRUE(tag_b.good());
- ASSERT_TRUE(tag_b.Get(ID).ServerKnows());
- ASSERT_TRUE(ids_.FromNumber(101) == tag_b.Get(ID));
+ EXPECT_TRUE(tag_b.Get(ID).ServerKnows());
+ EXPECT_EQ(ids_.FromNumber(101), tag_b.Get(ID));
EXPECT_FALSE(tag_b.Get(IS_DEL));
EXPECT_FALSE(tag_b.Get(IS_UNAPPLIED_UPDATE));
EXPECT_FALSE(tag_b.Get(IS_UNSYNCED));
@@ -4385,8 +4385,8 @@ TEST_F(SyncerTest, ClientTagClashWithinBatchOfUpdates) {
Entry tag_c(&trans, GET_BY_CLIENT_TAG, "tag c");
ASSERT_TRUE(tag_c.good());
- ASSERT_TRUE(tag_c.Get(ID).ServerKnows());
- ASSERT_TRUE(ids_.FromNumber(201) == tag_c.Get(ID));
+ EXPECT_TRUE(tag_c.Get(ID).ServerKnows());
+ EXPECT_EQ(ids_.FromNumber(201), tag_c.Get(ID));
EXPECT_FALSE(tag_c.Get(IS_DEL));
EXPECT_FALSE(tag_c.Get(IS_UNAPPLIED_UPDATE));
EXPECT_FALSE(tag_c.Get(IS_UNSYNCED));
« no previous file with comments | « chrome/browser/sync/engine/process_updates_command.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698