Issue 3054019: Reset to defaults failed to reset the Autofill/Mac/Address Book card preference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3054019: Reset to defaults failed to reset the Autofill/Mac/Address Book card preference (Closed)

Created:
10 years, 4 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Reset to defaults failed to reset the Autofill/Mac/Address Book card preference Adds awareness of kAutoFillAuxiliaryProfilesEnabled preference to |OptionsUtil::ResetToDefaults()|, which is used to reset preferences from the "Under the Hood" / "Reset to Defaults" button. BUG=49873 TEST=AutoFillManagerTest.AuxiliaryProfilesReset Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53845

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing review comments. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	chrome/browser/autofill/autofill_manager_unittest.cc	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
	M	chrome/browser/options_util.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

LGTM http://codereview.chromium.org/3054019/diff/1/2 File chrome/browser/autofill/autofill_manager_unittest.cc (right): http://codereview.chromium.org/3054019/diff/1/2#newcode1196 chrome/browser/autofill/autofill_manager_unittest.cc:1196: ASSERT_TRUE(profile()->GetPrefs()->GetBoolean( Add comment "aux profiles is Mac Address ...

10 years, 4 months ago (2010-07-27 21:13:12 UTC) #2

dhollowa

10 years, 4 months ago (2010-07-27 21:25:37 UTC) #3

http://codereview.chromium.org/3054019/diff/1/2
File chrome/browser/autofill/autofill_manager_unittest.cc (right):

http://codereview.chromium.org/3054019/diff/1/2#newcode1196
chrome/browser/autofill/autofill_manager_unittest.cc:1196:
ASSERT_TRUE(profile()->GetPrefs()->GetBoolean(
On 2010/07/27 21:13:13, John Grabowski wrote:
> Add comment "aux profiles is Mac Address Book" which only exists on Mac

Done.

Expand Messages | Collapse Messages