Issue 3054001: Adjust mac 10.5 startup expectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3054001: Adjust mac 10.5 startup expectations. (Closed)

Created:
10 years, 5 months ago by chase

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Adjust mac 10.5 startup expectations. After the most recent reboot, the startup results difference is ~30 ms. Adjust to keep the step green for now. BUG=none TEST=mac 10.5 startup is green TBR=nsylvain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52935

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/perf_expectations/perf_expectations.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

10 years, 5 months ago (2010-07-19 21:09:03 UTC) #2

lg

On Mon, Jul 19, 2010 at 12:10 PM, <chase@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Adjust mac 10.5 startup expectations.
>
> After the most recent reboot, the startup results
> difference is ~30 ms.  Adjust to keep the step green
> for now.
>
> BUG=none
> TEST=mac 10.5 startup is green
> TBR=nsylvain@chromium.org
>
> Please review this at http://codereview.chromium.org/3054001/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M tools/perf_expectations/perf_expectations.json
>
>
> Index: tools/perf_expectations/perf_expectations.json
> diff --git a/tools/perf_expectations/perf_expectations.json
> b/tools/perf_expectations/perf_expectations.json
> index
>
e7960909b30d12549e84b699c00b7a3203e73ba7..d27d18ffa2eaca60b66d5ca0d7df0c64d86ce129
> 100644
> --- a/tools/perf_expectations/perf_expectations.json
> +++ b/tools/perf_expectations/perf_expectations.json
> @@ -15,7 +15,7 @@
>  "mac-release-10.5/intl2/times/t": {"delta": 400, "var": 120},
>  "mac-release-10.5/morejs/times/t": {"delta": -35, "var": 80},
>  "mac-release-10.5/moz/times/t": {"delta": 80, "var": 80},
> - "mac-release-10.5/startup/warm/t": {"delta": 0, "var": 20},
> + "mac-release-10.5/startup/warm/t": {"delta": 30, "var": 20},
>  "mac-release-10.6/dhtml/times/t": {"delta": -12, "var": 14},
>  "mac-release-10.6/intl1/times/t": {"delta": 480, "var": 110},
>  "mac-release-10.6/intl2/times/t": {"delta": 300, "var": 60},
>
>
>

Expand Messages | Collapse Messages