Issue 3053042: Modify polymorphic keyed load IC stub to load cached properties from the prop...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3053042: Modify polymorphic keyed load IC stub to load cached properties from the prop... (Closed)

Created:
10 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Modify polymorphic keyed load IC stub to load cached properties from the property array of a fast-case JSObject. Committed: http://code.google.com/p/v8/source/detail?r=5175

Patch Set 3 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -12 lines)			Patch
M	src/arm/ic-arm.cc	View	1 2	4 chunks	+12 lines, -5 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 2	4 chunks	+11 lines, -3 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 2	3 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/3053042/diff/5001/6001 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/3053042/diff/5001/6001#newcode1206 src/arm/ic-arm.cc:1206: __ cmp(r5, r6); This could be a sub ...

10 years, 4 months ago (2010-08-05 10:32:05 UTC) #2

William Hesse

10 years, 4 months ago (2010-08-05 10:44:48 UTC) #3

http://codereview.chromium.org/3053042/diff/5001/6001
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/3053042/diff/5001/6001#newcode1206
src/arm/ic-arm.cc:1206: __ cmp(r5, r6);
On 2010/08/05 10:32:05, Erik Corry wrote:
> This could be a sub with SetCC.

Done.

Expand Messages | Collapse Messages

Issue 3053042: Modify polymorphic keyed load IC stub to load cached properties from the prop... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages