Issue 3053016: Not check versions of BIOS. Checking hash is enough.

Issue 3053016: Not check versions of BIOS. Checking hash is enough. (Closed)

Created:
10 years, 5 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
petkov, Hung-Te, Randall Spangler, Louis

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
ssh://gitrw.chromium.org/autotest.git

Visibility:
Public.

Description

Not check versions of BIOS. Checking hash is enough. The BIOS versions are not required in our spec.

Patch Set 2 : nothing changed #

Total comments: 2

Patch Set 3 : grep and ignore_status=True #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -70 lines)			Patch
	M	client/site_tests/hardware_Components/approved_components	View		2 chunks	+1 line, -1 line	0 comments	Download
	M	client/site_tests/hardware_Components/hardware_Components.py	View	1 2	4 chunks	+61 lines, -69 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM although you probably want to address the comment below. I realize, however, that this ...

10 years, 5 months ago (2010-07-27 04:05:47 UTC) #3

Tom Wai-Hong Tam

http://codereview.chromium.org/3053016/diff/3001/4002 File client/site_tests/hardware_Components/hardware_Components.py (right): http://codereview.chromium.org/3053016/diff/3001/4002#newcode214 client/site_tests/hardware_Components/hardware_Components.py:214: part_id = utils.system_output(cmd).strip() Add a flag ignore_status=True for system_output ...

10 years, 5 months ago (2010-07-27 08:25:23 UTC) #4

LGTM

Expand Messages | Collapse Messages