net/base/x509_certificate_mac.cc - Issue 3052035: Mac: Look for issuer in a certificate chain instead of subject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_certificate_mac.cc

Issue 3052035: Mac: Look for issuer in a certificate chain instead of subject (Closed)

Patch Set: Add unit test Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/x509_certificate_mac.cc

diff --git a/net/base/x509_certificate_mac.cc b/net/base/x509_certificate_mac.cc

index 23c3fa4a031f462c6a969cea6cda379ad9c0f3b9..e4c5c7f693317ee9862a973872ad0cf1a625b3af 100644

--- a/net/base/x509_certificate_mac.cc

+++ b/net/base/x509_certificate_mac.cc

@@ -861,7 +861,7 @@ bool X509Certificate::IsIssuedBy(

X509Certificate::SOURCE_LONE_CERT_IMPORT,

X509Certificate::OSCertHandles());

for (unsigned j = 0; j < valid_issuers.size(); j++) {

- if (cert->subject().Matches(valid_issuers[j]))

+ if (cert->issuer().Matches(valid_issuers[j]))

wtc 2010/08/03 03:25:54 No wonder this bug looks familiar to me. I noted

return true;

}