Issue 3052015: Disabled internal PDF by default....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3052015: Disabled internal PDF by default.... (Closed)

Created:
10 years, 5 months ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, jam, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disabled internal PDF by default. BUG=None TEST=Verify that the internal PDF plugin is disabled by default.s Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53848

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/plugin_updater.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

10 years, 5 months ago (2010-07-27 17:37:29 UTC) #2

LGTM

On Tue, Jul 27, 2010 at 10:36 AM,  <sanjeevr@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Disabled internal PDF by default.
> BUG=None
> TEST=Verify that the internal PDF plugin is disabled by default.s
>
>
> Please review this at http://codereview.chromium.org/3052015/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/plugin_updater.cc
>
>
> Index: chrome/browser/plugin_updater.cc
> ===================================================================
> --- chrome/browser/plugin_updater.cc    (revision 53418)
> +++ chrome/browser/plugin_updater.cc    (working copy)
> @@ -88,7 +88,7 @@
>     NPAPI::PluginList::Singleton()->DisablePlugin(file_path);
>  }
>
> -static bool enable_internal_pdf_ = true;
> +static bool enable_internal_pdf_ = false;
>
>  void DisablePluginGroupsFromPrefs(Profile* profile) {
>   bool update_internal_dir = false;
>
>
>

Expand Messages | Collapse Messages