Issue 3052014: Fix unit tests for the ResourceDispatcherHost....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3052014: Fix unit tests for the ResourceDispatcherHost.... (Closed)

Created:
10 years, 5 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix unit tests for the ResourceDispatcherHost. A field of the ViewHostMsg_Resource_Request structure was uninitialized. Also, includes a fix for an ASSERT_EQ that listed the expected value second instead of first. R=oshima BUG=50002 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53820

Patch Set 1 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	chrome/test/data/valgrind/unit_tests.gtest_mac.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

This is what default constructors are for :-(

10 years, 5 months ago (2010-07-27 09:13:33 UTC) #2

oshima

10 years, 5 months ago (2010-07-27 18:01:39 UTC) #3

lgtm!

On 2010/07/27 09:13:33, darin wrote:
> This is what default constructors are for :-(

Expand Messages | Collapse Messages