Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 3052011: Make the resize gripper invisible.... (Closed)

Created:
10 years, 5 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
Finnur, Evan Stade
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Make the resize gripper invisible. BUG=50107 TEST=Resize gripper nest to browser actions container should no longer appear Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53732

Patch Set 1 #

Total comments: 9

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -350 lines) Patch
M app/resources/app_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D app/resources/resize_gripper.png View Binary file 0 comments Download
M chrome/browser/gtk/browser_actions_toolbar_gtk.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/gtk/browser_actions_toolbar_gtk.cc View 1 4 chunks +2 lines, -26 lines 0 comments Download
M chrome/browser/views/browser_actions_container.h View 8 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/views/browser_actions_container.cc View 8 chunks +11 lines, -25 lines 0 comments Download
M chrome/browser/views/extensions/extension_installed_bubble.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + views/controls/resize_area.h View 3 chunks +11 lines, -20 lines 0 comments Download
A + views/controls/resize_area.cc View 4 chunks +20 lines, -56 lines 0 comments Download
D views/controls/resize_gripper.h View 1 chunk +0 lines, -76 lines 0 comments Download
D views/controls/resize_gripper.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M views/views.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Peter Kasting
I'll also remove resize_gripper.png in this change.
10 years, 5 months ago (2010-07-26 20:36:06 UTC) #1
Peter Kasting
Added estade to review the GTK bit. There's probably more simplification that can happen than ...
10 years, 5 months ago (2010-07-26 20:38:20 UTC) #2
Evan Stade
http://codereview.chromium.org/3052011/diff/1/3 File chrome/browser/gtk/browser_actions_toolbar_gtk.cc (left): http://codereview.chromium.org/3052011/diff/1/3#oldcode757 chrome/browser/gtk/browser_actions_toolbar_gtk.cc:757: if (!draw_gripper_) you can get rid of all references ...
10 years, 5 months ago (2010-07-26 20:41:15 UTC) #3
Peter Kasting
New snap up. I also removed a "gtk_widget_queue_draw()" call. http://codereview.chromium.org/3052011/diff/1/3 File chrome/browser/gtk/browser_actions_toolbar_gtk.cc (left): http://codereview.chromium.org/3052011/diff/1/3#oldcode757 chrome/browser/gtk/browser_actions_toolbar_gtk.cc:757: ...
10 years, 5 months ago (2010-07-26 20:58:13 UTC) #4
Finnur
http://codereview.chromium.org/3052011/diff/1/4 File chrome/browser/views/browser_actions_container.cc (left): http://codereview.chromium.org/3052011/diff/1/4#oldcode524 chrome/browser/views/browser_actions_container.cc:524: I take it you've tried starting with no extension ...
10 years, 5 months ago (2010-07-26 21:02:47 UTC) #5
Peter Kasting
http://codereview.chromium.org/3052011/diff/1/4 File chrome/browser/views/browser_actions_container.cc (left): http://codereview.chromium.org/3052011/diff/1/4#oldcode524 chrome/browser/views/browser_actions_container.cc:524: On 2010/07/26 21:02:47, Finnur wrote: > I take it ...
10 years, 5 months ago (2010-07-26 21:14:43 UTC) #6
Finnur
LGTM http://codereview.chromium.org/3052011/diff/1/4 File chrome/browser/views/browser_actions_container.cc (left): http://codereview.chromium.org/3052011/diff/1/4#oldcode524 chrome/browser/views/browser_actions_container.cc:524: Oh, right... On 2010/07/26 21:14:43, Peter Kasting wrote: ...
10 years, 5 months ago (2010-07-26 21:19:35 UTC) #7
Evan Stade
10 years, 5 months ago (2010-07-26 21:29:11 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698