Refactor HttpNetworkTransaction to eliminate the SPDY...

Minor change to: http://codereview.chromium.org/3064033
to fix valgrind detected memeory leak.  Instead of
storing the spdy session in a smart pointer member
field, use a smart pointer local var in the method.
We end up checking the pool twice, but c'est la vie.
 
Refactor HttpNetworkTransaction to eliminate the SPDY
specific states of the state machine.  This required
adding two new states:

      STATE_INIT_STREAM
      STATE_INTI_STREAM_COMPLETE

The http_stream_ and spdy_http_stream_ member fields
have been removed, and replaced by a single stream_
member field which is initialized with either an
HttpBasicStream, or SpdyHttpStream depending on the
underlying connection.

In the process, the NetLog no longer receives TYPE_SPDY
events, only TYPE_HTTP, so spdy_network_transaction_unittest.cc
needed to be modified accordingly.

BUG=50267
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55080

[Ryan Hamilton, 2010-08-05 16:24:18]

I thought I sent this yesterday, but it looks like I did not :<

[Mike Belshe, 2010-08-05 16:53:20]

I like this better. :-)

BTW - the CL description has a typo /INTI/INIT/

lgtm

[vandebo (ex-Chrome), 2010-08-05 20:52:49]

LGTM

http://codereview.chromium.org/3051034/diff/1/2
File net/http/http_network_transaction.cc (right):

http://codereview.chromium.org/3051034/diff/1/2#newcode1299
net/http/http_network_transaction.cc:1299: }
Did you dropped the 'else if (result < 0) stream_.reset()' on purpose?