Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10369)

Unified Diff: chrome_frame/chrome_frame_activex_base.h

Issue 3051018: Ensure that window.open requests issued by ChromeFrame carry the correct cook... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_active_document.cc ('k') | chrome_frame/protocol_sink_wrap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_frame_activex_base.h
===================================================================
--- chrome_frame/chrome_frame_activex_base.h (revision 53833)
+++ chrome_frame/chrome_frame_activex_base.h (working copy)
@@ -480,15 +480,19 @@
virtual void OnAttachExternalTab(int tab_handle,
const IPC::AttachExternalTabParams& params) {
- std::string url;
- url = StringPrintf("%lsattach_external_tab&%ls&%d&%d&%d&%d&%d",
- kChromeProtocolPrefix,
- Uint64ToWString(params.cookie).c_str(),
- params.disposition,
- params.dimensions.x(),
- params.dimensions.y(),
- params.dimensions.width(),
- params.dimensions.height());
+ std::wstring wide_url = url_;
+ GURL parsed_url(WideToUTF8(wide_url));
+
+ std::string url =
+ StringPrintf("%hs:%hs?attach_external_tab&%I64u&%d&%d&%d&%d&%d",
+ parsed_url.scheme().c_str(),
+ parsed_url.host().c_str(),
+ params.cookie,
+ params.disposition,
+ params.dimensions.x(),
+ params.dimensions.y(),
+ params.dimensions.width(),
+ params.dimensions.height());
HostNavigate(GURL(url), GURL(), params.disposition);
}
« no previous file with comments | « chrome_frame/chrome_active_document.cc ('k') | chrome_frame/protocol_sink_wrap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698