Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 3051013: Add logic to save input method preference based on user clicks. (Closed)

Created:
10 years, 5 months ago by satorux1
Modified:
9 years, 7 months ago
CC:
chromium-reviews, dhg, arv (Not doing code reviews), ben+cc_chromium.org
Visibility:
Public.

Description

Add logic to save input method preference based on user clicks. Along the way, add some sanity check code in language_options_list.js to filter bad language codes, just in case. TEST=manually BUG=chromium-os:4573 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53915

Patch Set 1 #

Total comments: 5

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -5 lines) Patch
M chrome/browser/resources/options/chromeos_language_list.js View 2 chunks +24 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/chromeos_language_options.js View 1 4 chunks +90 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
10 years, 5 months ago (2010-07-26 10:39:45 UTC) #1
satorux1
Friendly reminder just in case you missed it.
10 years, 5 months ago (2010-07-28 00:27:49 UTC) #2
arv (Not doing code reviews)
I did miss it :'( LGTM, just a few nits http://codereview.chromium.org/3051013/diff/1/3 File chrome/browser/resources/options/chromeos_language_options.js (right): http://codereview.chromium.org/3051013/diff/1/3#newcode149 ...
10 years, 5 months ago (2010-07-28 06:19:26 UTC) #3
satorux1
10 years, 5 months ago (2010-07-28 06:31:19 UTC) #4
Thanks! Will submit shortly.

http://codereview.chromium.org/3051013/diff/1/3
File chrome/browser/resources/options/chromeos_language_options.js (right):

http://codereview.chromium.org/3051013/diff/1/3#newcode149
chrome/browser/resources/options/chromeos_language_options.js:149: * engines
preference.
On 2010/07/28 06:19:27, arv wrote:
> @private

Done.

http://codereview.chromium.org/3051013/diff/1/3#newcode162
chrome/browser/resources/options/chromeos_language_options.js:162:
checkboxes[i].checked = true;
On 2010/07/28 06:19:27, arv wrote:
> checkboxes[i].checked = checkboxes[i].inputMethodId in dictionary;

Done.

http://codereview.chromium.org/3051013/diff/1/3#newcode171
chrome/browser/resources/options/chromeos_language_options.js:171: * input
method list.
Added @private here as well.

Powered by Google App Engine
This is Rietveld 408576698