Issue 3050047: fix print of total elapsed time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3050047: fix print of total elapsed time (Closed)

Created:
10 years, 4 months ago by Olof Johansson

Modified:
9 years, 7 months ago

Reviewers:
davidjames, Mandeep Singh Baines

CC:
chromium-os-reviews_chromium.org, anush, sosa, Mandeep Singh Baines

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

fix print of total elapsed time BUG=none TEST=run build_image, happen to finish on a time with less than 10 seconds in it, watch the missing 0-padding

Patch Set 2 : fixed long line #

Total comments: 1

Patch Set 3 : third time's a charm #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	common.sh	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mandeep Singh Baines

http://codereview.chromium.org/3050047/diff/1/2 File common.sh (right): http://codereview.chromium.org/3050047/diff/1/2#newcode455 common.sh:455: printf "Elapsed time: %d:%02d\n" $(( $elapsed_seconds / 60 )) ...

10 years, 4 months ago (2010-08-09 14:34:59 UTC) #2

Olof Johansson

On 2010/08/09 14:34:59, Mandeep Singh Baines wrote: > This exceeds 80-column. Silly me. PTAL.

10 years, 4 months ago (2010-08-09 18:15:30 UTC) #3

davidjames

LGTM w/comment http://codereview.chromium.org/3050047/diff/3002/5001 File common.sh (right): http://codereview.chromium.org/3050047/diff/3002/5001#newcode455 common.sh:455: printf "Elapsed time: %d:%02d\n" $(( $elapsed_seconds / ...

10 years, 4 months ago (2010-08-09 19:00:47 UTC) #4