Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 3050043: linux: pass --as-needed to linker (Closed)

Created:
10 years, 4 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

linux: pass --as-needed to linker Gentoo has some nice docs on it here: http://www.gentoo.org/proj/en/qa/asneeded.xml on my Maverick box I couldn't see a difference in the ldd output, but I suppose it can't hurt on older systems. BUG=11595 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55302

Patch Set 1 #

Patch Set 2 : ok #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
10 years, 4 months ago (2010-08-06 20:49:15 UTC) #1
Lei Zhang
Let me make sure it doesn't break dump_syms for Breakpad.
10 years, 4 months ago (2010-08-06 20:54:47 UTC) #2
Paweł Hajdan Jr.
Rubber stamp LGTM.
10 years, 4 months ago (2010-08-06 21:24:03 UTC) #3
Lei Zhang
10 years, 4 months ago (2010-08-06 22:26:09 UTC) #4
LGTM

Breakpad seems happy.

Powered by Google App Engine
This is Rietveld 408576698