Issue 3050039: clean up install_gpt args to use number of sectors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3050039: clean up install_gpt args to use number of sectors (Closed)

Created:
10 years, 4 months ago by Tan Gao

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

clean up install_gpt args to use number of sectors Change-Id: I7d17db3cb522a52ec2dac688f4bf83fb5ae6a2d1 related CL: http://codereview.chromium.org/3031049/show TEST=(1)Manually built an image using build_image script, which exercised "build_gpt.sh"; (2) manually built a Qemu VM image using "image_to_vm.sh" and verified the VM is bootable (up to login screen); (3) manually built a dev recovery image using "mod_image_for_dev_recovery.sh" and verified image functions properly for dev recovery purpose

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -6 lines)			Patch
M	build_gpt.sh	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	image_to_vm.sh	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	mod_image_for_dev_recovery.sh	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tan Gao

Hi Andrew, This is CL 1/2 to clean up install_gpt() (in platform/installer/chromeos-install). In brief, instead ...

10 years, 4 months ago (2010-08-05 23:42:42 UTC) #1

LGTM. Make sure to check in at the same time!

Expand Messages | Collapse Messages