Issue 3050037: Add test PKCS12 datafile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3050037: Add test PKCS12 datafile. (Closed)

Created:
10 years, 4 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Add test PKCS12 datafile. BUG=19991 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55118

Patch Set 1 #

Patch Set 2 : note the password in the readme #

Total comments: 1

Patch Set 3 : use wtc's readme wording #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	net/data/ssl/certificates/README	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
	A	net/data/ssl/certificates/client.p12	View		Binary file		0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

10 years, 4 months ago (2010-08-05 17:48:34 UTC) #2

LGTM.

http://codereview.chromium.org/3050037/diff/3001/4001
File net/data/ssl/certificates/README (right):

http://codereview.chromium.org/3050037/diff/3001/4001#newcode32
net/data/ssl/certificates/README:32: - client.p12 : A client certificate PKCS12
public/private key pair created for
Nit: PKCS12 => PKCS #12

I suggest this description:
  A PKCS #12 file containing a client certificate and a
  private key created for testing.  The password is "12345".

Expand Messages | Collapse Messages