Issue 3050018: New PyAuto tests for cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3050018: New PyAuto tests for cookies. (Closed)

Created:
10 years, 5 months ago by Alyssa

Modified:
9 years, 7 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

New PyAuto tests for cookies. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54011

Patch Set 2 : Nits #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -1 line)			Patch
	A	chrome/test/data/setcookie.html	View		1 chunk	+16 lines, -0 lines	0 comments	Download
	M	chrome/test/functional/cookies.py	View	1	2 chunks	+45 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

LGTM http://codereview.chromium.org/3050018/diff/3001/4002 File chrome/test/functional/cookies.py (right): http://codereview.chromium.org/3050018/diff/3001/4002#newcode14 chrome/test/functional/cookies.py:14: http_url = 'http://www.google.com' member vars begin with _ ...

10 years, 5 months ago (2010-07-27 18:22:32 UTC) #2

Alyssa

10 years, 4 months ago (2010-07-28 17:28:27 UTC) #3

http://codereview.chromium.org/3050018/diff/3001/4002
File chrome/test/functional/cookies.py (right):

http://codereview.chromium.org/3050018/diff/3001/4002#newcode14
chrome/test/functional/cookies.py:14: http_url = 'http://www.google.com'
On 2010/07/27 18:22:32, Nirnimesh wrote:
> member vars begin with _

Realized they didn't need to be member variables any more.

http://codereview.chromium.org/3050018/diff/3001/4002#newcode22
chrome/test/functional/cookies.py:22: def _CookieCheckRegular(self, url):
On 2010/07/27 18:22:32, Nirnimesh wrote:
> Regular -> RegularWindow

Done.

Expand Messages | Collapse Messages

Issue 3050018: New PyAuto tests for cookies. (Closed)

Description

Patch Set 1 : Initial #

Patch Set 2 : Nits #

Messages