Issue 3049002: Update vista morejs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3049002: Update vista morejs. (Closed)

Created:
10 years, 5 months ago by chase

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Update vista morejs. Looks like we got faster around r50331 (WebKit roll 61498:61520). BUG=none TEST=vista morejs is green TBR=nsylvain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52926

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/perf_expectations/perf_expectations.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

10 years, 5 months ago (2010-07-19 19:01:00 UTC) #2

lgtm

On Mon, Jul 19, 2010 at 11:54 AM, <chase@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Update vista morejs.
>
> Looks like we got faster around r50331 (WebKit roll
> 61498:61520).
>
> BUG=none
> TEST=vista morejs is green
> TBR=nsylvain@chromium.org
>
> Please review this at http://codereview.chromium.org/3049002/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M tools/perf_expectations/perf_expectations.json
>
>
> Index: tools/perf_expectations/perf_expectations.json
> diff --git a/tools/perf_expectations/perf_expectations.json
> b/tools/perf_expectations/perf_expectations.json
> index
>
37da73d47b66f32d0a5a8af7f20700ba6e9bc907..e7960909b30d12549e84b699c00b7a3203e73ba7
> 100644
> --- a/tools/perf_expectations/perf_expectations.json
> +++ b/tools/perf_expectations/perf_expectations.json
> @@ -25,7 +25,7 @@
>  "vista-release-dual-core/dhtml/times/t": {"delta": 10, "var": 20},
>  "vista-release-dual-core/intl1/times/t": {"delta": 140, "var": 60},
>  "vista-release-dual-core/intl2/times/t": {"delta": 40, "var": 40},
> - "vista-release-dual-core/morejs/times/t": {"delta": 0, "var": 30},
> + "vista-release-dual-core/morejs/times/t": {"delta": -120, "var": 30},
>  "vista-release-dual-core/moz/times/t": {"delta": 0, "var": 60},
>  "vista-release-dual-core/startup/times/t": {"delta": 0, "var": 10},
>  "vista-release-single-core/dhtml/times/t": {"delta": 0, "var": 60},
>
>
>

Expand Messages | Collapse Messages