Issue 3048037: Add "stop on" stanza to cashew upstart script to prevent repeated respawning during system shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3048037: Add "stop on" stanza to cashew upstart script to prevent repeated respawning during system shutdown. (Closed)

Created:
10 years, 4 months ago by Vince Laviano

Modified:
9 years ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, Vince Laviano

Base URL:
ssh://git@gitrw.chromium.org:9222/cashew.git

Visibility:
Public.

Description

Add "stop on" stanza to cashew upstart script to prevent repeated respawning during system shutdown. BUG=chromium-os:5245 TEST=Shutdown system and observe from logs that cashew is not respawned repeatedly.

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/cashew.conf	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

10 years, 4 months ago (2010-07-30 18:56:29 UTC) #2

LGTM

On Fri, Jul 30, 2010 at 11:38 AM,  <vlaviano@chromium.org> wrote:
> Reviewers: cmasone,
>
> Description:
> Add "stop on" stanza to cashew upstart script to prevent repeated respawning
> during system shutdown.
>
> BUG=chromium-os:5245
> TEST=Shutdown system and observe from logs that cashew is not respawned
> repeatedly.
>
> Please review this at http://codereview.chromium.org/3048037/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/cashew.git
>
> Affected files:
>  M src/cashew.conf
>
>
> Index: src/cashew.conf
> diff --git a/src/cashew.conf b/src/cashew.conf
> index
>
3eb40f902457c22fd6ab075241e88fb13bedfcdd..c1d300100d0c0fce89cbeeda53dbc57268f81670
> 100644
> --- a/src/cashew.conf
> +++ b/src/cashew.conf
> @@ -5,5 +5,6 @@
>  # cashew upstart job
>
>  start on started flimflam
> +stop on starting halt or starting reboot
>  respawn
>  exec /usr/sbin/cashewd --log_dir=/var/log/cashew --logbuflevel=-1
>
>
>

Expand Messages | Collapse Messages