Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 3048035: Fix error in optimized x.apply(y, arguments) code generation on ARM. Fixes i... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-784.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1610 matching lines...) Expand 10 before | Expand all | Expand 10 after
1621 // Then process it as a normal function call. 1621 // Then process it as a normal function call.
1622 __ ldr(r0, MemOperand(sp, 3 * kPointerSize)); 1622 __ ldr(r0, MemOperand(sp, 3 * kPointerSize));
1623 __ ldr(r1, MemOperand(sp, 2 * kPointerSize)); 1623 __ ldr(r1, MemOperand(sp, 2 * kPointerSize));
1624 __ Strd(r0, r1, MemOperand(sp, 2 * kPointerSize)); 1624 __ Strd(r0, r1, MemOperand(sp, 2 * kPointerSize));
1625 1625
1626 CallFunctionStub call_function(2, NOT_IN_LOOP, NO_CALL_FUNCTION_FLAGS); 1626 CallFunctionStub call_function(2, NOT_IN_LOOP, NO_CALL_FUNCTION_FLAGS);
1627 frame_->CallStub(&call_function, 3); 1627 frame_->CallStub(&call_function, 3);
1628 // The function and its two arguments have been dropped. 1628 // The function and its two arguments have been dropped.
1629 frame_->Drop(); // Drop the receiver as well. 1629 frame_->Drop(); // Drop the receiver as well.
1630 frame_->EmitPush(r0); 1630 frame_->EmitPush(r0);
1631 frame_->SpillAll(); // A spilled frame is also jumping to label done.
1631 // Stack now has 1 element: 1632 // Stack now has 1 element:
1632 // sp[0]: result 1633 // sp[0]: result
1633 __ bind(&done); 1634 __ bind(&done);
1634 1635
1635 // Restore the context register after a call. 1636 // Restore the context register after a call.
1636 __ ldr(cp, frame_->Context()); 1637 __ ldr(cp, frame_->Context());
1637 } 1638 }
1638 1639
1639 1640
1640 void CodeGenerator::Branch(bool if_true, JumpTarget* target) { 1641 void CodeGenerator::Branch(bool if_true, JumpTarget* target) {
(...skipping 9748 matching lines...) Expand 10 before | Expand all | Expand 10 after
11389 __ bind(&string_add_runtime); 11390 __ bind(&string_add_runtime);
11390 __ TailCallRuntime(Runtime::kStringAdd, 2, 1); 11391 __ TailCallRuntime(Runtime::kStringAdd, 2, 1);
11391 } 11392 }
11392 11393
11393 11394
11394 #undef __ 11395 #undef __
11395 11396
11396 } } // namespace v8::internal 11397 } } // namespace v8::internal
11397 11398
11398 #endif // V8_TARGET_ARCH_ARM 11399 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-784.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698