Issue 3048009: build_image: avoid losetup -c because older kernels seem to balk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3048009: build_image: avoid losetup -c because older kernels seem to balk (Closed)

Created:
10 years, 5 months ago by Will Drewry

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

build_image: avoid losetup -c because older kernels seem to balk Instead of resizing the loop device after adding padding for the hash tree data. Just ensure that the mkfs.ext3 call doesn't exceed the rootfs size. TEST=reran build_image on my lucid machine and checked the rootfs size; asked someone with hardy machine to test. BUG=none Change-Id: I59f95e1d17e35aca265bd44bb863da6069c05bd2

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix extra line #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	build_image	View	1	1 chunk	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sosa

lgtm w/ nit http://codereview.chromium.org/3048009/diff/1/2 File build_image (right): http://codereview.chromium.org/3048009/diff/1/2#newcode539 build_image:539: Nit: Remove extra line

10 years, 5 months ago (2010-07-21 20:03:42 UTC) #2

Will Drewry

Fixed and pushing! On 2010/07/21 20:03:42, sosa wrote: > lgtm w/ nit > > http://codereview.chromium.org/3048009/diff/1/2 ...

10 years, 5 months ago (2010-07-21 20:08:27 UTC) #3

sosa

10 years, 5 months ago (2010-07-21 20:09:00 UTC) #4

Thanks!

On Wed, Jul 21, 2010 at 1:08 PM,  <wad@chromium.org> wrote:
> Fixed and pushing!
>
> On 2010/07/21 20:03:42, sosa wrote:
>>
>> lgtm w/ nit
>
>> http://codereview.chromium.org/3048009/diff/1/2
>> File build_image (right):
>
>> http://codereview.chromium.org/3048009/diff/1/2#newcode539
>> build_image:539:
>> Nit: Remove extra line
>
>
>
> http://codereview.chromium.org/3048009/show
>

Expand Messages | Collapse Messages