Issue 3048008: Add support to update_engine_client for -app_version and -omaha_url.

Issue 3048008: Add support to update_engine_client for -app_version and -omaha_url. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, ericli, seano

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

Add support to update_engine_client for -app_version and -omaha_url. These options prevent auto-detection of these parameters. Note that this CL makes the check_for_update DBus method obsolete from the client's point of view. BUG=4593 TEST=unit tests, gmerged on device and tried the client with different options.

Patch Set 1 #

Patch Set 2 : minor fixes #

Total comments: 4

Patch Set 3 : Don't use ?: shorthand. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+247 lines, -119 lines)			Patch
M	UpdateEngine.conf	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	dbus_service.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	dbus_service.cc	View	1 2	2 chunks	+16 lines, -4 lines	0 comments	Download
M	main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	omaha_request_action.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	omaha_request_params.h	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	omaha_request_params.cc	View		1 chunk	+15 lines, -5 lines	0 comments	Download
M	omaha_request_params_unittest.cc	View		4 chunks	+162 lines, -84 lines	0 comments	Download
M	update_attempter.h	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	update_attempter.cc	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	update_engine.xml	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	update_engine_client.cc	View	1	4 chunks	+20 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

http://codereview.chromium.org/3048008/diff/2001/3002 File dbus_service.cc (right): http://codereview.chromium.org/3048008/diff/2001/3002#newcode75 dbus_service.cc:75: const string update_app_version = app_version ?: ""; is this ...

10 years, 5 months ago (2010-07-22 01:26:02 UTC) #2

petkov

10 years, 5 months ago (2010-07-22 16:43:43 UTC) #3

Pushing when the tree is open...

http://codereview.chromium.org/3048008/diff/2001/3002
File dbus_service.cc (right):

http://codereview.chromium.org/3048008/diff/2001/3002#newcode75
dbus_service.cc:75: const string update_app_version = app_version ?: "";
On 2010/07/22 01:26:02, adlr wrote:
> is this the the ternary operator? is this shorthand for
> app_version ? app_version : ""
> ?
> 
> if so, LGTM

Yes it is a shorthand. I changed it to the full form though because (a) I think
the shorthand might be a GCC extension and (b) you asked about it.

http://codereview.chromium.org/3048008/diff/2001/3002#newcode76
dbus_service.cc:76: const string update_omaha_url = omaha_url ?: "";
On 2010/07/22 01:26:02, adlr wrote:
> same

Switched to full form.

Expand Messages | Collapse Messages