Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 3048002: Store creating url in origin nodes and use it for content settings. (Closed)

Created:
10 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Store creating url in origin nodes and use it for content settings. BUG=none TEST=Cookies*.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52910

Patch Set 1 #

Patch Set 2 : check before creating settings #

Patch Set 3 : compilefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -174 lines) Patch
M chrome/browser/browsing_data_database_helper.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data_database_helper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/cookie_details_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/cookies_window_controller_unittest.mm View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/cookies_tree_model.h View 1 4 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/cookies_tree_model.cc View 1 7 chunks +48 lines, -33 lines 0 comments Download
M chrome/browser/cookies_tree_model_unittest.cc View 1 19 chunks +91 lines, -21 lines 0 comments Download
M chrome/browser/gtk/options/cookies_view_unittest.cc View 47 chunks +101 lines, -101 lines 0 comments Download
M chrome/browser/mock_browsing_data_database_helper.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/mock_browsing_data_local_storage_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
please review
10 years, 5 months ago (2010-07-19 13:45:43 UTC) #1
Bernhard Bauer
10 years, 5 months ago (2010-07-19 14:05:07 UTC) #2
On 2010/07/19 13:45:43, jochen wrote:
> please review

LGTM assuming trybots pass.

Powered by Google App Engine
This is Rietveld 408576698