Issue 3047038: Added support for ES5's propertyname production.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3047038: Added support for ES5's propertyname production. (Closed)

Created:
10 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Added support for ES5's propertyname production. Object initialisers and dot-notation property access allows keywords in ES5. Also allowed non-identifiers after "get" or "set" in an object initialiser.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -24 lines)			Patch
M	src/parser.cc	View	1	8 chunks	+45 lines, -13 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+5 lines, -6 lines	0 comments	Download
M	src/token.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/token.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	test/mjsunit/object-literal.js	View		1 chunk	+107 lines, -0 lines	0 comments	Download
M	test/sputnik/sputnik.status	View		2 chunks	+15 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/3047038/diff/1/2 File src/parser.cc (right): http://codereview.chromium.org/3047038/diff/1/2#newcode3641 src/parser.cc:3641: #define CASE_KEYWORD(name, ignore1, ignore2) \ Please make a ...

10 years, 4 months ago (2010-08-02 12:01:46 UTC) #2

Lasse Reichstein

10 years, 4 months ago (2010-08-02 12:08:19 UTC) #3

http://codereview.chromium.org/3047038/diff/1/2
File src/parser.cc (right):

http://codereview.chromium.org/3047038/diff/1/2#newcode3641
src/parser.cc:3641: #define CASE_KEYWORD(name, ignore1, ignore2) \
Done.

http://codereview.chromium.org/3047038/diff/1/3
File src/runtime.cc (right):

http://codereview.chromium.org/3047038/diff/1/3#newcode312
src/runtime.cc:312: // If key is a symbol that is not an array element.
I'll change the comment to
// The key is not an array index.
The rest should be obvious from the condition.

Expand Messages | Collapse Messages