Issue 3046051: cros_mark_as_stable: modify push to use tracking branch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3046051: cros_mark_as_stable: modify push to use tracking branch (Closed)

Created:
10 years, 4 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
petkov, Nasser Grainawi, anush, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, sosa

Base URL:
http://src.chromium.org/git/crosutils.git

Visibility:
Public.

Description

cros_mark_as_stable: modify push to use tracking branch BUG=5258 TEST=Successfully pushed. Change-Id: I985da7577e88f4a734f8281cae4aafce8dda5933

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	cros_mark_as_stable.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

anush

LGTM On 2010/08/05 18:35:00, Mandeep Singh Baines wrote: >

10 years, 4 months ago (2010-08-05 18:36:20 UTC) #3

Nasser Grainawi

10 years, 4 months ago (2010-08-05 18:39:48 UTC) #4

lgtm w/ a nit

http://codereview.chromium.org/3046051/diff/1/2
File cros_mark_as_stable.py (right):

http://codereview.chromium.org/3046051/diff/1/2#newcode39
cros_mark_as_stable.py:39: gflags.DEFINE_string('tracking_branch', 'origin',
You should really be explicit here and use 'origin/master'. 'origin' isn't a
branch, it's a remote.

Expand Messages | Collapse Messages