Issue 3046049: Add information about memory allocator's size and capacity and heap snapshot into heap stats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3046049: Add information about memory allocator's size and capacity and heap snapshot into heap stats. (Closed)

Created:
10 years, 4 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Visibility:
Public.

Description

Add information about memory allocator's size and capacity and heap snapshot into heap stats. That might help us debug OOM crashes in V8. Committed: http://code.google.com/p/v8/source/detail?r=5181

Patch Set 2 : Make taking snapshot an optional step #

Patch Set 3 : Add a comment that snapshotting is not quite precise #

Total comments: 2

Patch Set 4 : Slava's variant of wording #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -28 lines)			Patch
M	src/api.cc	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
M	src/heap.h	View	1	2 chunks	+25 lines, -21 lines	0 comments	Download
M	src/heap.cc	View	1 2 3	2 chunks	+18 lines, -1 line	0 comments	Download
M	src/heap-inl.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/v8.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/3046049/diff/5/6003 File src/heap.cc (right): http://codereview.chromium.org/3046049/diff/5/6003#newcode4135 src/heap.cc:4135: // so snapshot won't be precise. Maybe something ...

10 years, 4 months ago (2010-08-05 12:58:08 UTC) #2

antonm

10 years, 4 months ago (2010-08-05 13:26:19 UTC) #3

Thanks a lot for review, Slava, and for all suggestions.

http://codereview.chromium.org/3046049/diff/5/6003
File src/heap.cc (right):

http://codereview.chromium.org/3046049/diff/5/6003#newcode4135
src/heap.cc:4135: // so snapshot won't be precise.
On 2010/08/05 12:58:09, Vyacheslav Egorov wrote:
> Maybe something like this:
> 
> // Note: snapshot won't be precise because IsFreeListNode returns true for any
> bytearray. 
> 
> 

Done.