Revert 54074 - Add initial tests for keyboard access (tabbing in some dialogs...

Revert 54074 - Add initial tests for keyboard access (tabbing in some dialogs).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3015026

TBR=dtseng@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54093

[David Tseng, 2010-07-29 16:13:33]

Thanks for the note.  How do I go about scheduling another patch
against the win dbg bot?  (gcl try -b windbg?).

On 7/28/10, rohitrao@chromium.org <rohitrao@chromium.org> wrote:
> Reviewers: David Tseng,
>
> Description:
> Revert 54074 - Add initial tests for keyboard access (tabbing in some
> dialogs).
> BUG=none
> TEST=none
> Review URL: http://codereview.chromium.org/3015026
>
> TBR=dtseng@chromium.org
>
> Please review this at http://codereview.chromium.org/3046031/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>    M     chrome/browser/autocomplete/autocomplete_edit_view_win.cc
>    M     chrome/browser/views/bookmark_bar_view_test.cc
>    D     chrome/browser/views/browser_keyboard_accessibility_test_win.cc
>    M     chrome/browser/views/chrome_views_delegate.h
>    M     chrome/test/interactive_ui/interactive_ui_tests.gypi
>    M     views/controls/native_control.cc
>    M     views/view.h
>    M     views/view_gtk.cc
>    M     views/view_unittest.cc
>    M     views/view_win.cc
>    M     views/views_delegate.h
>
>
>

[rohitrao (ping after 24h), 2010-07-29 16:15:40]

I think by default the bots run in debug mode, so -b win should give
you a windows debug bot.  I don't really understand why your cl passed
on the trybots but failed on the waterfall bots.

On Thu, Jul 29, 2010 at 12:12 PM, David Tseng <dtseng@chromium.org> wrote:
> Thanks for the note.  How do I go about scheduling another patch
> against the win dbg bot?  (gcl try -b windbg?).
>
> On 7/28/10, rohitrao@chromium.org <rohitrao@chromium.org> wrote:
>> Reviewers: David Tseng,
>>
>> Description:
>> Revert 54074 - Add initial tests for keyboard access (tabbing in some
>> dialogs).
>> BUG=none
>> TEST=none
>> Review URL: http://codereview.chromium.org/3015026
>>
>> TBR=dtseng@chromium.org
>>
>> Please review this at http://codereview.chromium.org/3046031/show
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>
>> Affected files:
>>    M     chrome/browser/autocomplete/autocomplete_edit_view_win.cc
>>    M     chrome/browser/views/bookmark_bar_view_test.cc
>>    D     chrome/browser/views/browser_keyboard_accessibility_test_win.cc
>>    M     chrome/browser/views/chrome_views_delegate.h
>>    M     chrome/test/interactive_ui/interactive_ui_tests.gypi
>>    M     views/controls/native_control.cc
>>    M     views/view.h
>>    M     views/view_gtk.cc
>>    M     views/view_unittest.cc
>>    M     views/view_win.cc
>>    M     views/views_delegate.h
>>
>>
>>
>

[David Tseng, 2010-07-29 17:56:10]

I've been unable to reproduce the debug check indicated in the log
locally after trying for a while this morning.  Any suggestions as to
how to proceed?

On 7/29/10, Rohit Rao <rohitrao@chromium.org> wrote:
> I think by default the bots run in debug mode, so -b win should give
> you a windows debug bot.  I don't really understand why your cl passed
> on the trybots but failed on the waterfall bots.
>
> On Thu, Jul 29, 2010 at 12:12 PM, David Tseng <dtseng@chromium.org> wrote:
>> Thanks for the note.  How do I go about scheduling another patch
>> against the win dbg bot?  (gcl try -b windbg?).
>>
>> On 7/28/10, rohitrao@chromium.org <rohitrao@chromium.org> wrote:
>>> Reviewers: David Tseng,
>>>
>>> Description:
>>> Revert 54074 - Add initial tests for keyboard access (tabbing in some
>>> dialogs).
>>> BUG=none
>>> TEST=none
>>> Review URL: http://codereview.chromium.org/3015026
>>>
>>> TBR=dtseng@chromium.org
>>>
>>> Please review this at http://codereview.chromium.org/3046031/show
>>>
>>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>>
>>> Affected files:
>>>    M     chrome/browser/autocomplete/autocomplete_edit_view_win.cc
>>>    M     chrome/browser/views/bookmark_bar_view_test.cc
>>>    D     chrome/browser/views/browser_keyboard_accessibility_test_win.cc
>>>    M     chrome/browser/views/chrome_views_delegate.h
>>>    M     chrome/test/interactive_ui/interactive_ui_tests.gypi
>>>    M     views/controls/native_control.cc
>>>    M     views/view.h
>>>    M     views/view_gtk.cc
>>>    M     views/view_unittest.cc
>>>    M     views/view_win.cc
>>>    M     views/views_delegate.h
>>>
>>>
>>>
>>
>

[rohitrao (ping after 24h), 2010-07-29 18:23:23]

I know very little about interactive_ui_tests.  Maybe someone in IRC
will know more?

Sorry =(

On Thu, Jul 29, 2010 at 1:55 PM, David Tseng <dtseng@chromium.org> wrote:
> I've been unable to reproduce the debug check indicated in the log
> locally after trying for a while this morning.  Any suggestions as to
> how to proceed?
>
> On 7/29/10, Rohit Rao <rohitrao@chromium.org> wrote:
>> I think by default the bots run in debug mode, so -b win should give
>> you a windows debug bot.  I don't really understand why your cl passed
>> on the trybots but failed on the waterfall bots.
>>
>> On Thu, Jul 29, 2010 at 12:12 PM, David Tseng <dtseng@chromium.org> wrote:
>>> Thanks for the note.  How do I go about scheduling another patch
>>> against the win dbg bot?  (gcl try -b windbg?).
>>>
>>> On 7/28/10, rohitrao@chromium.org <rohitrao@chromium.org> wrote:
>>>> Reviewers: David Tseng,
>>>>
>>>> Description:
>>>> Revert 54074 - Add initial tests for keyboard access (tabbing in some
>>>> dialogs).
>>>> BUG=none
>>>> TEST=none
>>>> Review URL: http://codereview.chromium.org/3015026
>>>>
>>>> TBR=dtseng@chromium.org
>>>>
>>>> Please review this at http://codereview.chromium.org/3046031/show
>>>>
>>>> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>>>>
>>>> Affected files:
>>>>    M     chrome/browser/autocomplete/autocomplete_edit_view_win.cc
>>>>    M     chrome/browser/views/bookmark_bar_view_test.cc
>>>>    D     chrome/browser/views/browser_keyboard_accessibility_test_win.cc
>>>>    M     chrome/browser/views/chrome_views_delegate.h
>>>>    M     chrome/test/interactive_ui/interactive_ui_tests.gypi
>>>>    M     views/controls/native_control.cc
>>>>    M     views/view.h
>>>>    M     views/view_gtk.cc
>>>>    M     views/view_unittest.cc
>>>>    M     views/view_win.cc
>>>>    M     views/views_delegate.h
>>>>
>>>>
>>>>
>>>
>>
>